Hi,

I am having problems with my popup menus (BuildPopMenu,BuildPopMenu1,DoPopUp,DoPopUp1)
Nothing happens when I select a popup menu item

I want it to change pen color and pen size

Another problem I am running into is the pen size menu also displays the pen color menu
I want different meuitems in pen size

local fn BuildPopMenu( id as long )
'~'1
dim as MenuRef m

menu id, 0, _enable, ""
menu id, 1, _enable, "Black;White;Red;Green;Blue;Cyan;Magenta;Yellow;-;Eraser;-;Select another color..."

m = fn GetMenuHandle( id )
DeleteMenu( id )
InsertMenu( m, -1 )
end fn

case _btnClick
select ( window( _outputWnd ) )
case _ToolsWnd
select ( id )
case _cPopPenColor
fn DoPopUp (101)
case _cPopPenSize
fn DoPopUp1 (102)

local fn BuildPopMenu1( id as long )
'~'1
dim as MenuRef m

menu id, 1, _enable, ""
menu id, 2, _enable, "1;2;3;4;5;6;7;8;9"
m = fn GetMenuHandle( id )
DeleteMenu( id )
InsertMenu( m, -1 )
end fn

local fn DoPopup( menuID as long )
'~'1
dim as Long     mItem
dim as Str255   txtStr
dim as MenuRef  mRef
dim as Long     outWnd

mItem = button( menuID )
mRef  = button( menuID, _FBgetControlMenuHandle )
call GetMenuItemText( mRef, mItem, @txtStr )

outWnd = window( _storyteller)
window output _storyteller
select case ( mItem)
case "Black"  : Color = _zBlack
case "Yellow" : Color = _zYellow
case "Green"  : Color = _zGreen
case "Cyan"   : Color = _zCyan
case "Blue"   : Color = _zBlue
case "Magenta": Color = _zMagenta
case "Red"    : Color = _zRed
end select

if outWnd then window output outWnd

end fn


local fn DoPopUp1( menuID as long)
'~'1
dim as Long     mItem
dim as Str255   txtStr
dim as MenuRef  mRef
dim as Long     outWnd

mItem = button( menuID )
mRef  = button( menuID, _FBgetControlMenuHandle )
call GetMenuItemText( mRef, mItem, @txtStr )

outWnd = window( _storyteller)
window output _storyteller
select case (mItem)
case 1: PenSize( 1,1)
case 2: PenSize( 2,2)
case 3: PenSize( 3,3)
case 4: PenSize( 4,4)
case 5: PenSize( 5,5)
case 6: PenSize( 6,6)
case 7: PenSize( 7,7)
case 8: PenSize( 8,8)
case 9: PenSize( 9,9)
end select
end fn

Any advice on how to fix this appreciated.

Brian