On 5/02/2012, at 5:30 PM, Robert Covington wrote:

> I have confirmed this.
> 
> If I alter FBAppearanceWindow to set the title right after window creation, but before the official default FB handlers are installed, the name remains as it should.  

Good detective work.

> Q to be answered: What could change the reference of titlePtr in FBAppearanceWindow between it's good form before window creation, and bad one, after, due to string stack work as a result of the handlers called in the interim before titlePtr is set just a few lines down the road, in AppThings.c?

Your DoDialog handler performs some string manipulation that overwrites the string stack entry used for the title.
The reason is that FBAppearanceWindow() pops the stack too soon. 

I think this should fix it.

Comment out the line:
    //if ( titlePtr ) gFBStk--;
and instead insert:
    Boolean  popStackOnExit = ( titlePtr != NULL );


Insert a line after the label CantCreateWindow:
    if ( popStackOnExit ) gFBStk--;